-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic regional dex rating #3900
Conversation
should not be blocking: I understand that the static array for Jirachi and Deoxys work just fine, but that sounds like it should be a member of the Pokemon struct, like |
I believe making it a member of the struct will make the process slightly longer since we need to check that value for each mon in the dex as opposed to just going through the list, but it's a very fair remark. Since this is going to master, I think we could potentially consider it blocking, so feedback from others would be highly appreciated here |
imho, merge this one as is, make an issue for later to address |
Can anybody provide a save that this can be tested with? /Edi sorry, I'm stupid. I don't need a save. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine if this goes to master since it fixes an obvious bug.
@pkmnsnfrn Could you please open an issue ticket?
This PR completely overhauls the regional dex rating. Features:
This is currently based on master since it's a bugfix (imo), but can be rebased to upcoming if considered too invasive for master.
Issue(s) that this PR fixes
Fixes #3874
Discord contact info
bassoonian